feat: Support Signed-By option for apt repository#14131
feat: Support Signed-By option for apt repository#14131tpowell-progress merged 1 commit intochef:mainfrom
Conversation
1c8059d to
1cfd9d8
Compare
25ee2b6 to
508ba35
Compare
|
508ba35 to
b84cc1c
Compare
|
|
If we can get this to non-draft and rebase on |
b84cc1c to
34018df
Compare
34018df to
075dc1b
Compare
schrd
left a comment
There was a problem hiding this comment.
looks like some variable renamings have been missed
075dc1b to
22c151f
Compare
|
|
@tmccombs can we get another rebase to validate that everything is working in the tests? |
If it is used, it will avoid using the deprecated apt-key command. Fixes: chef#13168 Signed-Off-By: Thayne Mccombs <thayne@lucid.co>
22c151f to
ed80452
Compare
|
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
Signed-off-by: Thomas Powell <thomas.powell@progress.com>




If it is used, it will avoid using the deprecated apt-key command.
Fixes: #13168
Description
Add support for a
signed_byproperty for apt_repository.If true, and a key is supplied, it will install the key in a repo-specific keyring, and reference that in the Signed-By option.
If a string, it will pass that string to the Signed-By option.
I'm not sure what the behavior should be if signed_by is a string, and a key is also supplied. Currently it will install the key in a repo-specific location, but use the value of the string in the signed-by field.
Other options for the case where key and signed-by are both specified could be:
This still needs testing and documentation. But I wanted to see if this was a good approach before polishing it.
Related Issue
#13168
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.