[Chef-17] Fix error due to method name conflict in Azure Secrets Manager#14439
Merged
[Chef-17] Fix error due to method name conflict in Azure Secrets Manager#14439
Conversation
neha-p6
changed the title
neha-p6
force-pushed
the
neha-p6/CHEF-8029_fix_azure_secret
branch
from
a8fc484 to
9c645fb
Compare
|
johnmccrae
approved these changes
Jun 18, 2024
jaymzh
reviewed
Jun 25, 2024
|
|
||
| def validate! | ||
| raise Chef::Exceptions::Secret::ConfigurationInvalid, "You may only specify one (these are mutually exclusive): :object_id, :client_id, or :mi_res_id" if [object_id, client_id, mi_res_id].count { |x| !x.nil? } > 1 | ||
| raise Chef::Exceptions::Secret::ConfigurationInvalid, "You may only specify one (these are mutually exclusive): :config_object_id, :client_id, or :mi_res_id" if [object_id, client_id, mi_res_id].count { |x| !x.nil? } > 1 |
Collaborator
There was a problem hiding this comment.
don't you need to change this one too.
Suggested change
| raise Chef::Exceptions::Secret::ConfigurationInvalid, "You may only specify one (these are mutually exclusive): :config_object_id, :client_id, or :mi_res_id" if [object_id, client_id, mi_res_id].count { |x| !x.nil? } > 1 | |
| raise Chef::Exceptions::Secret::ConfigurationInvalid, "You may only specify one (these are mutually exclusive): :config_object_id, :client_id, or :mi_res_id" if [config_object_id, client_id, mi_res_id].count { |x| !x.nil? } > 1 |
tpowell-progress
added
the
Status: Waiting on Contributor
…e to conflict with default ruby method Signed-off-by: Neha Pansare <neha.pansare@progress.com>
Signed-off-by: Neha Pansare <neha.pansare@progress.com>
neha-p6
force-pushed
the
neha-p6/CHEF-8029_fix_azure_secret
branch
from
c31dc30 to
5793f5c
Compare
|
Collaborator
Author
|
Openssl 3.0.9 upgrade changes are yet to be merged to chef17, hence merging this PR with the failures in place (as they are about Openssl) |
neha-p6
removed
the
Status: Waiting on Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename object_id action in azure vault resource as it throws error due to conflict with default ruby method
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.