Skip to content

[Chef-18] Mixlib-Log compatibility with AIX and Ruby 3.0#14864

Closed
johnmccrae wants to merge 11 commits intochef-18from
jfm/chef18-aix-mixlib-log-issue
Closed

[Chef-18] Mixlib-Log compatibility with AIX and Ruby 3.0#14864
johnmccrae wants to merge 11 commits intochef-18from
jfm/chef18-aix-mixlib-log-issue

Conversation

@johnmccrae
Copy link
Copy Markdown
Contributor

@johnmccrae johnmccrae commented Feb 27, 2025

Description

The current build config loads mixlib-log-3.2.0. This version is incompatible with Ruby 3.0 which we're using on AIX only. We are updating the gemfile to choose the correct version of mixlib-log based on RUBY_PLATFORM

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
@johnmccrae johnmccrae marked this pull request as ready for review February 28, 2025 23:30
@johnmccrae johnmccrae requested review from a team as code owners February 28, 2025 23:30
Copy link
Copy Markdown
Contributor

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to include the rdoc spec in an install_if

neha-p6
neha-p6 previously requested changes Mar 5, 2025
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
Signed-off-by: John <john.mccrae@progress.com>
@rahulgoel1 rahulgoel1 closed this Mar 11, 2025
@johnmccrae johnmccrae reopened this Mar 13, 2025
@sonarqubecloud
Copy link
Copy Markdown

@johnmccrae johnmccrae dismissed stale reviews from neha-p6 and tpowell-progress March 13, 2025 17:48

Completed

@jaymzh
Copy link
Copy Markdown
Collaborator

jaymzh commented Mar 18, 2025

Closing, was merged elsewhere.

@jaymzh jaymzh closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants