[Backport 18] Reverse the default for only_record_changes #14883
Merged
tpowell-progress merged 2 commits intochef-18from Mar 6, 2025
Merged
[Backport 18] Reverse the default for only_record_changes #14883tpowell-progress merged 2 commits intochef-18from
tpowell-progress merged 2 commits intochef-18from
Conversation
Accidental push to chef-18 This reverts commit 220235d. Signed-off-by: Thomas Powell <thomas.powell@progress.com>
* Reverse the default for only_record_changes * Stubs are wrong for unit tests --------- Signed-off-by: Thomas Powell <thomas.powell@progress.com>
johnmccrae
approved these changes
Mar 5, 2025
|
4 tasks
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per discussions with the customer who opened the ticket and reasoning about the nature of registry keys and values, it was determined that the more surprising and error prone behavior was to report all values within a key, regardless of change. Switching the default due to this.
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.