Removing Knife from Chef#15847
Merged
Merged
Conversation
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
jaymzh
requested changes
Apr 6, 2026
Collaborator
jaymzh
left a comment
jaymzh
left a comment
There was a problem hiding this comment.
This will actually fix one of our last remaining dependabot errors.
And I'm generally +1 on this.
But not until we fix up the other repo to at least know it's authoritatve and give the proper prms.
Also https://buildkite.com/chef/chef-knife-main-habitat-test/builds/452 should probably be open.
Collaborator
|
that repo also needs its own gemfile.lock. I'm prep'ing a PR with the CI stuff in the meantime. |
Collaborator
|
chef/knife#74 is a first-pass |
Collaborator
|
Also, another code sync is probably necessary, at the very least the copyright notice fixes are not present over there. |
johnmccrae
force-pushed
the
jfm/chef19-removing-knife
branch
from
87da73d to
af32a08
Compare
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
Collaborator
|
Also this PR should add knife to the list of repos to review in the docs/ directory |
jaymzh
added a commit
to jaymzh/knife
that referenced
this pull request
Apr 7, 2026
According to chef/chef#15847 this is going to become the authoritative repo for knife. Other things need to happen for that, but this is a first-pass at cleaning things up. * add lint * add unit * add DCO * fix line endings * fix spellcheck * Update various configs for new paths and non existent paths * Add CODEOWNERS * Add dependabot config * add .editorconfig * add Gemfile.lock Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
added a commit
to jaymzh/knife
that referenced
this pull request
Apr 7, 2026
According to chef/chef#15847 this is going to become the authoritative repo for knife. Other things need to happen for that, but this is a first-pass at cleaning things up. * add lint * add unit * add DCO * fix line endings * fix spellcheck * Update various configs for new paths and non existent paths * Add CODEOWNERS * Add dependabot config * add .editorconfig * add Gemfile.lock Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
added a commit
to jaymzh/knife
that referenced
this pull request
Apr 7, 2026
According to chef/chef#15847 this is going to become the authoritative repo for knife. Other things need to happen for that, but this is a first-pass at cleaning things up. * add lint * add unit * add DCO * fix line endings * fix spellcheck * Update various configs for new paths and non existent paths * Add CODEOWNERS * Add dependabot config * add .editorconfig * add Gemfile.lock Signed-off-by: Phil Dibowitz <phil@ipom.com>
tpowell-progress
approved these changes
Apr 7, 2026
Contributor
tpowell-progress
left a comment
tpowell-progress
left a comment
There was a problem hiding this comment.
Hold on merge until https://github.com/chef/knife/pull/74/changes merges
jaymzh
added a commit
to jaymzh/knife
that referenced
this pull request
Apr 7, 2026
According to chef/chef#15847 this is going to become the authoritative repo for knife. Other things need to happen for that, but this is a first-pass at cleaning things up. * add lint * add unit * add DCO * fix line endings * fix spellcheck * Update various configs for new paths and non existent paths * Add CODEOWNERS * Add dependabot config * add .editorconfig * add Gemfile.lock Signed-off-by: Phil Dibowitz <phil@ipom.com>
tpowell-progress
requested changes
Apr 7, 2026
Contributor
tpowell-progress
left a comment
tpowell-progress
left a comment
There was a problem hiding this comment.
Hold until @jaymzh's request
jaymzh
added a commit
to jaymzh/knife
that referenced
this pull request
Apr 7, 2026
According to chef/chef#15847 this is going to become the authoritative repo for knife. Other things need to happen for that, but this is a first-pass at cleaning things up. * add lint * add unit * add DCO * fix line endings * fix spellcheck * Update various configs for new paths and non existent paths * Add CODEOWNERS * Add dependabot config * add .editorconfig * add Gemfile.lock Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
added a commit
to jaymzh/knife
that referenced
this pull request
Apr 7, 2026
According to chef/chef#15847 this is going to become the authoritative repo for knife. Other things need to happen for that, but this is a first-pass at cleaning things up. * add lint * add unit * add DCO * fix line endings * fix spellcheck * Update various configs for new paths and non existent paths * Add CODEOWNERS * Add dependabot config * add .editorconfig * add Gemfile.lock Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
added a commit
to jaymzh/knife
that referenced
this pull request
Apr 7, 2026
According to chef/chef#15847 this is going to become the authoritative repo for knife. Other things need to happen for that, but this is a first-pass at cleaning things up. * add lint * add unit * add DCO * fix line endings * fix spellcheck * Update various configs for new paths and non existent paths * Add CODEOWNERS * Add dependabot config * add .editorconfig * add Gemfile.lock Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
added a commit
to jaymzh/knife
that referenced
this pull request
Apr 7, 2026
According to chef/chef#15847 this is going to become the authoritative repo for knife. Other things need to happen for that, but this is a first-pass at cleaning things up. * add lint * add unit * add DCO * fix line endings * fix spellcheck * Update various configs for new paths and non existent paths * Add CODEOWNERS * Add dependabot config * add .editorconfig * add Gemfile.lock Signed-off-by: Phil Dibowitz <phil@ipom.com>
Collaborator
|
@johnmccrae - rather than have the Knife TODOs all over the place I created a single Issue with a checklist: chef/knife#77 and assigned it to you. |
jaymzh
added a commit
to jaymzh/knife
that referenced
this pull request
Apr 8, 2026
According to chef/chef#15847 this is going to become the authoritative repo for knife. Other things need to happen for that, but this is a first-pass at cleaning things up. * add lint * add unit * add DCO * fix line endings * fix spellcheck * Update various configs for new paths and non existent paths * Add CODEOWNERS * Add dependabot config * add .editorconfig * add Gemfile.lock Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
added a commit
to chef/knife
that referenced
this pull request
Apr 8, 2026
According to chef/chef#15847 this is going to become the authoritative repo for knife. Other things need to happen for that, but this is a first-pass at cleaning things up. * add lint * add unit * add DCO * fix line endings * fix spellcheck * Update various configs for new paths and non existent paths * Add CODEOWNERS * Add dependabot config * add .editorconfig * add Gemfile.lock Signed-off-by: Phil Dibowitz <phil@ipom.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
johnmccrae
force-pushed
the
jfm/chef19-removing-knife
branch
from
a4cfd87 to
a802d92
Compare
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
Signed-off-by: John McCrae <john.mccrae@progress.com>
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
|
jaymzh
approved these changes
Apr 13, 2026
jaymzh
added a commit
to jaymzh/chef
that referenced
this pull request
Apr 14, 2026
This reverts commit c22a635. Signed-off-by: Phil Dibowitz <phil@ipom.com>
johnmccrae
temporarily deployed
to
workflow_guard
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Knife was moved to it's own repo. It currently holds a Chef-19 era version. We needed to remove local references to knife and all the local knife files/folders to match that. Knife will load as a gem from the repo and not Rubygems for now.
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.