Sync with upstream #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgsql_connection processes will automatically initiate a Postgres sync exchange with the database when a database error occurs. This insures the connection is always in a sane state and relieves external callers from having to care about syncing the connection after an error.
|
Looks reasonable to me. Have we tried getting our patches merged upstream? Would it make sense to create a new branch and rebase our patches on top of upstream? |
Author
|
Looks like we have tried: wg#14. |
|
probably good to stay up-to-date. projects have this locked down anyway right? so we can update project-by-project? |
|
+1 on this. I've got another patch coming which adds some more array types too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using arrays in stored procedures in Bifrost now. The upstream repo has a couple commits that add to / fix array support. This addresses the bit of interestingness I found at chef-boneyard/oc_bifrost@f711e58
The unit tests pass, but this hasn't yet been tested in the rest of our applications (erchef, bifrost, reporting, etc.). Putting it out for consideration now, though.