Ma/v4 signing #28
Closed
Ma/v4 signing #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Anderson <mark@chef.io>
|
|
||
| %% AWS V4 requires sorting; | ||
| %% Each header is terminated with a "\n" | ||
| make_header_string(Headers) -> |
Member
There was a problem hiding this comment.
Nit: Arguably this could called from canonicalize_headers' instead of make_v4_canonical_request since as amazon describes the canonical header it itself as both sorted and lowercase
Signed-off-by: Mark Anderson <mark@chef.io>
Contributor
|
We decided to support only v4 signing since support for sig_V2 has now ended and all the old sig_v2 buckets should also support sig_V4. https://aws.amazon.com/blogs/aws/amazon-s3-update-sigv2-deprecation-period-extended-modified/ (Will reopen if required) REF to sig_V4 work: chef/chef-server#2097 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Types of changes
Checklist: