fix global state pollution issues across examples#54
Merged
Conversation
since classes are global state, having a single TestCLI class that threads through all the examples creates state pollution that can cause ordering problems. solve this by rewiring TestCLI to a new class every single time. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
tas50
reviewed
Jan 4, 2019
| # | ||
| # Author:: Adam Jacob (<adam@chef.io>) | ||
| # Copyright:: Copyright (c) 2008-2016 Chef Software, Inc. | ||
| # Copyright:: Copyright (c) 2008-2018, Chef Software Inc. |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since classes are global state, having a single TestCLI class that
threads through all the examples creates state pollution that can
cause ordering problems.
solve this by rewiring TestCLI to a new class every single time.