modernize shell testing

[Stromweld]

Description

• Switch to modern shell testing using [] instead of test command
• Update script_generator for licensed downloads
• Add missing code spec test files
• Remove unused option :new_omnibus_download_url
• Code optimizations

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[jaymzh]

One more cleanup

[sonarqubecloud]

Quality Gate passed

Issues
75 New issues
0 Accepted issues

Measures
2 Security Hotspots
0.0% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

[jaymzh]

@IanMadd - can you approve this for docs-team? Also... how do you feel about removing docs-team from *.md blocking?

[IanMadd]

@IanMadd - can you approve this for docs-team? Also... how do you feel about removing docs-team from *.md blocking?

Yeah, that's fine. There's no customer facing content here.