Add the zoom export parameter to the relevant method#13
Merged
chekos merged 1 commit intochekos:masterfrom Mar 25, 2021
Merged
Conversation
Owner
|
I'll review this week! Apologies for the delay! |
Owner
|
Looks great!! |
Contributor
Author
|
Awesome, thanks! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! 😄
I was using this package (thanks!) yesterday and noticed that the
export_chart()method does not have a parameter for thezoomone, according to the Datawrapper documentation. If I understand correctly, this parameter is basically what allows you to "scale" the images in PNG format, in order to generate images with better quality/resolution, while thescaleparameter is for the PDF format.In this way, this PR, if considered relevant, simply adds a new parameter (
zoom) to theexport_chart()method, in order to be able to customize the scale when exporting PNGs (there were also some whitespaces removed when I saved the file, but since they were small adjustments, I thought about keeping them — I hope it is ok). I also tested this approach here (with a monkey patch).Feel free to ask for clarification or to suggest changes. I hope this tiny PR can be useful! 😄