Skip to content

feat(column): add exclude_from_color_key field to ColumnChart#501

Merged
palewire merged 1 commit intochekos:mainfrom
palewire:main
Nov 1, 2025
Merged

feat(column): add exclude_from_color_key field to ColumnChart#501
palewire merged 1 commit intochekos:mainfrom
palewire:main

Conversation

@palewire
Copy link
Collaborator

@palewire palewire commented Nov 1, 2025

refactor(value_labels): remove value_labels_always from serialization

refactor(value_labels): remove value_labels_always from serialization
@palewire palewire requested a review from Copilot November 1, 2025 16:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the redundant value_labels_always field from the ValueLabels deserializer output and adds support for excluding columns from the color key in column charts.

  • Removes value_labels_always from deserialization output as it's redundant (the show_value_labels field already captures this information)
  • Adds exclude_from_color_key field to ColumnChart with proper serialization support
  • Updates all related test assertions to reflect the removed field

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
datawrapper/charts/serializers/value_labels.py Removes redundant value_labels_always field from deserialize method output
tests/unit/serializers/test_value_labels.py Updates test assertions to remove checks for value_labels_always field
datawrapper/charts/column.py Adds exclude_from_color_key field and integrates it into color category serialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@palewire palewire merged commit f6b7c8f into chekos:main Nov 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant