feat(column): add exclude_from_color_key field to ColumnChart#501
Merged
palewire merged 1 commit intochekos:mainfrom Nov 1, 2025
Merged
feat(column): add exclude_from_color_key field to ColumnChart#501palewire merged 1 commit intochekos:mainfrom
palewire merged 1 commit intochekos:mainfrom
Conversation
refactor(value_labels): remove value_labels_always from serialization
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the redundant value_labels_always field from the ValueLabels deserializer output and adds support for excluding columns from the color key in column charts.
- Removes
value_labels_alwaysfrom deserialization output as it's redundant (theshow_value_labelsfield already captures this information) - Adds
exclude_from_color_keyfield to ColumnChart with proper serialization support - Updates all related test assertions to reflect the removed field
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| datawrapper/charts/serializers/value_labels.py | Removes redundant value_labels_always field from deserialize method output |
| tests/unit/serializers/test_value_labels.py | Updates test assertions to remove checks for value_labels_always field |
| datawrapper/charts/column.py | Adds exclude_from_color_key field and integrates it into color category serialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(value_labels): remove value_labels_always from serialization