feat: simplify export parameters for PNG and PDF methods#517
Merged
palewire merged 2 commits intochekos:mainfrom Dec 1, 2025
Merged
feat: simplify export parameters for PNG and PDF methods#517palewire merged 2 commits intochekos:mainfrom
palewire merged 2 commits intochekos:mainfrom
Conversation
- Remove hardcoded "mode": "rgb" parameter from PNG export - Remove "plain" parameter from PDF export query params - Add type annotation for params dict in PDF export method These changes simplify the export API calls by removing unnecessary default parameters, allowing the server to use its own defaults.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies export API calls by removing unnecessary hardcoded parameters from PNG and SVG export methods. However, there is a critical bug: the SVG export method removes the plain parameter from the query params while still accepting it in the function signature, breaking the API contract.
Key changes:
- Removes hardcoded
"mode": "rgb"from PNG export (appropriate since PNG export doesn't have a mode parameter) - Removes
"plain"parameter from SVG export query params (bug: breaks functionality) - Adds type annotation to SVG export params dict
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
``` test: remove default parameter assertions from export tests Remove assertions for default parameters that are no longer being sent in PNG and SVG export requests: - Remove 'mode' parameter check from PNG export test - Remove 'plain' parameter check from SVG export test These parameters are likely now handled server-side or have been removed from the API request logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes simplify the export API calls by removing unnecessary default parameters, allowing the server to use its own defaults.