Skip to content

feat!: update React to v19 - #4358

Merged
targos merged 1 commit into
mainfrom
react-19
Sep 10, 2026
Merged

feat!: update React to v19#4358
targos merged 1 commit into
mainfrom
react-19

Conversation

@targos

@targos targos commented Sep 2, 2026

Copy link
Copy Markdown
Member

Closes: #3315

Draft because there is a significant performance drop in development, probably fixed by react/react#36913 (but there is no release with it yet). Updated to React 19.3.0.

Cloudflare preview in production mode is not affected.

@targos
targos marked this pull request as draft September 2, 2026 10:10
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 2, 2026

Copy link
Copy Markdown

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9559acc
Status: ✅  Deploy successful!
Preview URL: https://137df308.nmrium.pages.dev
Branch Preview URL: https://react-19.nmrium.pages.dev

View logs

@targos
targos marked this pull request as ready for review September 10, 2026 06:36
@tpoisseau

Copy link
Copy Markdown
Contributor
% npm ci
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: react-popper@2.3.0
npm warn Found: react@19.3.0
npm warn node_modules/react
npm warn   dev react@"^19.3.0" from the root project
npm warn   44 more (@blueprintjs/core, @blueprintjs/icons, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^16.8.0 || ^17 || ^18" from react-popper@2.3.0
npm warn node_modules/@blueprintjs/core/node_modules/react-popper
npm warn   react-popper@"^2.3.0" from @blueprintjs/core@6.18.0
npm warn   node_modules/@blueprintjs/core
npm warn
npm warn Conflicting peer dependency: react@18.3.1
npm warn node_modules/react
npm warn   peer react@"^16.8.0 || ^17 || ^18" from react-popper@2.3.0
npm warn   node_modules/@blueprintjs/core/node_modules/react-popper
npm warn     react-popper@"^2.3.0" from @blueprintjs/core@6.18.0
npm warn     node_modules/@blueprintjs/core
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: react-popper@2.3.0
npm warn Found: react-dom@19.3.0
npm warn node_modules/react-dom
npm warn   dev react-dom@"^19.3.0" from the root project
npm warn   24 more (@blueprintjs/core, @blueprintjs/icons, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react-dom@"^16.8.0 || ^17 || ^18" from react-popper@2.3.0
npm warn node_modules/@blueprintjs/core/node_modules/react-popper
npm warn   react-popper@"^2.3.0" from @blueprintjs/core@6.18.0
npm warn   node_modules/@blueprintjs/core
npm warn
npm warn Conflicting peer dependency: react-dom@18.3.1
npm warn node_modules/react-dom
npm warn   peer react-dom@"^16.8.0 || ^17 || ^18" from react-popper@2.3.0
npm warn   node_modules/@blueprintjs/core/node_modules/react-popper
npm warn     react-popper@"^2.3.0" from @blueprintjs/core@6.18.0
npm warn     node_modules/@blueprintjs/core
npm warn deprecated eslint@9.39.5: This version is no longer supported. Please see https://eslint.org/version-support for other options.

Is it OK, should we do something about react-popper ?

@tpoisseau tpoisseau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@targos
targos merged commit d8f6ad6 into main Sep 10, 2026
12 checks passed
@targos
targos deleted the react-19 branch September 10, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate to React version 19

2 participants