Conversation
… issues - Split monolithic useEcharts (404 LOC) into orchestrator + 6 internal hooks: useInstanceLifecycle, useOptionSync, useLoading, useEvents, useGroup, useResizeObserver - Add shallowEqual utility for option update deduplication - Extract syncGroupConnectivity in connect.ts to eliminate duplicated logic - Fix clearInstanceCache to dispose tracked instances before clearing - Make EChart component responsive with height:100% + minHeight:400px - Add circular reference protection for theme objects in JSON.stringify - Fix RAF ID not cleared after execution in resize observer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
===========================================
- Coverage 100.00% 98.87% -1.13%
===========================================
Files 10 18 +8
Lines 399 443 +44
Branches 92 104 +12
===========================================
+ Hits 399 438 +39
- Misses 0 5 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useEchartshook (404 → 148 LOC) into orchestrator + 6 focused internal hooks undersrc/hooks/internal/shallowEqualutility for option update deduplication, preventing unnecessarysetOptioncallssyncGroupConnectivityinconnect.tsto eliminate duplicated connect/disconnect logicclearInstanceCacheto properly dispose all tracked instances before clearingEChartcomponent responsive withheight: 100%+minHeight: 400px(was fixed400px)JSON.stringifyTest plan
vp test run)vp check)vp pack)dist/index.d.tsdoes not expose any internal hooks🤖 Generated with Claude Code