Skip to content

test: achieve 100% coverage across all metrics#346

Merged
chensid merged 1 commit intomainfrom
develop
Apr 13, 2026
Merged

test: achieve 100% coverage across all metrics#346
chensid merged 1 commit intomainfrom
develop

Conversation

@chensid
Copy link
Copy Markdown
Owner

@chensid chensid commented Apr 13, 2026

Summary

  • Add circular reference theme tests covering computeThemeKey WeakMap cache hit branch
  • Remove unreachable defensive branch in clearInstanceCache (trackedElements and instanceCache are always in sync)
  • Exclude pure type/declaration files from coverage config (vite-env.d.ts, types/, index.ts barrel)
  • Add v8 ignore annotation for forwardRef false branch in EChart.tsx

Test plan

  • 139 tests pass
  • 100% coverage: Statements, Branches, Functions, Lines — all files
  • Zero lint/type errors (vp check)

🤖 Generated with Claude Code

- Add circular reference theme tests covering computeThemeKey WeakMap cache hit
- Remove unreachable defensive branch in clearInstanceCache (trackedElements
  and instanceCache are always in sync)
- Exclude pure type/declaration files from coverage (vite-env.d.ts, types/,
  index.ts barrel)
- Add v8 ignore annotation for forwardRef false branch in EChart.tsx

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@chensid chensid merged commit 1c1e205 into main Apr 13, 2026
1 check passed
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (468fa6d) to head (778103b).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #346      +/-   ##
===========================================
+ Coverage   98.87%   100.00%   +1.12%     
===========================================
  Files          18        18              
  Lines         443       433      -10     
  Branches      104        95       -9     
===========================================
- Hits          438       433       -5     
+ Misses          5         0       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant