SyncthingService: Don't wait for runner thread to exit#135
Merged
Conversation
Syncthing sometimes takes upwards of 10 seconds to exit, which can cause Android to show an ANR warning. We don't actually need to wait because even if the shutdown takes a while and the user tries to start up the service again in the meantime, stbridge's global lock will prevent any race conditions. The startup just won't begin until the previous shutdown completes. Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
May 16, 2026
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncthing sometimes takes upwards of 10 seconds to exit, which can cause Android to show an ANR warning. We don't actually need to wait because even if the shutdown takes a while and the user tries to start up the service again in the meantime, stbridge's global lock will prevent any race conditions. The startup just won't begin until the previous shutdown completes.