fix: restore SQL SSL URL normalization#442
Merged
chenyme merged 2 commits intochenyme:mainfrom Apr 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sslmode/ssl-mode/sslquery params from DSNs and pass them through dialect-specificconnect_argssslmode=requireand MySQLssl-mode=REQUIREDWhy
Recent upstream changes reintroduced a startup regression for SQL-backed config storage. When
ACCOUNT_POSTGRESQL_URLincluded?sslmode=require, the config backend passed the raw query string into SQLAlchemy/asyncpg and startup failed with:This restores the earlier behavior from the old storage implementation in the new shared SQL engine factory, so both account storage and config storage handle SSL query params correctly.
Validation
uv run python -m unittest tests.test_sql_engine_ssluv run ruff check app/control/account/backends/sql.py tests/test_sql_engine_ssl.pyACCOUNT_STORAGE=postgresql ACCOUNT_POSTGRESQL_URL='postgres://...?...sslmode=require' uv run python - <<'PY' ... create_config_backend().version() ... PY127.0.0.1and the TCP connection is refused before SQL auth/handshake