-
Notifications
You must be signed in to change notification settings - Fork 52
feat: Oracle module (SMA, WMA, EMA) #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into prathyusha/upgrade_resource
…into prathyusha/upgrade_resource
* wip * wip * wip * wip * feat(params): add migrator support to did module * feat: add autocli support * wip * fix * wip * chore: remove comment * chore: add migrate * chore: add migration in module.go * feat: add SetParams function * go.mod
…into prathyusha/upgrade_resource
…into prathyusha/upgrade_resource
…nto vishal/oracle
…nto vishal/oracle
…g window as param
Introduces pre-upgrade integration tests for v4.1, supporting scripts and environment files, and updates the CI workflow to run and report these tests. Also adjusts upgrade scripts and test logic to support sequential upgrades and corrects proposal IDs for v4.2.
Eengineer1
approved these changes
Nov 3, 2025
Member
Eengineer1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final signoff is on point!
Approved 👍.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the fee abstraction and fee market modules, focusing on improved integration with the oracle module and more robust fee handling in tests. The main changes include updating test logic to account for oracle fee sharing, expanding test coverage for fee abstraction scenarios, and refactoring decorators to include oracle dependencies. These updates help ensure that fee distribution and conversion logic are correctly validated and that the oracle module is properly integrated into post-transaction processing.
Fee distribution and oracle integration:
TaxDecoratorin tests to includeOracleKeeperandPriceFeederdependencies, ensuring oracle integration in post-transaction logic. [1] [2] [3] [4] [5] [6] [7]Fee abstraction and conversion logic:
DenomResolverImpl.ConvertToDenom, ensuring correct zero-value coin creation when needed.Test setup and coverage:
Interface and dependency updates:
OracleKeeperandPriceFeederinterfaces inexpected_keepers.goto support oracle integration and exchange rate retrieval.Miscellaneous:
.dockerignoreto no longer ignore thetestsdirectory, ensuring test files are available in Docker builds.These changes collectively improve the reliability, accuracy, and coverage of fee processing and oracle integration in both the codebase and CI testing.