Skip to content

Conversation

@vishal-kanna
Copy link
Collaborator

@vishal-kanna vishal-kanna commented May 8, 2025

This pull request introduces enhancements to the fee abstraction and fee market modules, focusing on improved integration with the oracle module and more robust fee handling in tests. The main changes include updating test logic to account for oracle fee sharing, expanding test coverage for fee abstraction scenarios, and refactoring decorators to include oracle dependencies. These updates help ensure that fee distribution and conversion logic are correctly validated and that the oracle module is properly integrated into post-transaction processing.

Fee distribution and oracle integration:

  • Updated fee tests to check correct reward splitting between the fee collector and the oracle module, including calculation and verification of the oracle's 0.5% share of transaction fees. [1] [2]
  • Refactored all instances of the TaxDecorator in tests to include OracleKeeper and PriceFeeder dependencies, ensuring oracle integration in post-transaction logic. [1] [2] [3] [4] [5] [6] [7]

Fee abstraction and conversion logic:

  • Enhanced fee abstraction tests to cover conversion of IBC-denominated fees to native tokens, with updated fee amounts and account funding for more realistic scenarios. [1] [2]
  • Improved handling of zero-amount conversions in DenomResolverImpl.ConvertToDenom, ensuring correct zero-value coin creation when needed.

Test setup and coverage:

  • Added initialization of oracle averages in relevant fee tests to ensure consistent test results and proper oracle module behavior. [1] [2] [3]

Interface and dependency updates:

  • Introduced new OracleKeeper and PriceFeeder interfaces in expected_keepers.go to support oracle integration and exchange rate retrieval.
  • Updated imports across test and keeper files to support new oracle and math dependencies. [1] [2] [3]

Miscellaneous:

  • Minor update to .dockerignore to no longer ignore the tests directory, ensuring test files are available in Docker builds.
  • Expanded CI workflow steps to include additional upgrade test stages and artifact uploads for improved test reporting. [1] [2]

These changes collectively improve the reliability, accuracy, and coverage of fee processing and oracle integration in both the codebase and CI testing.

akhilkumarpilli and others added 30 commits April 9, 2025 16:55
* wip

* wip

* wip

* wip

* feat(params): add migrator support to did module

* feat: add autocli support

* wip

* fix

* wip

* chore: remove comment

* chore: add migrate

* chore: add migration in module.go

* feat: add SetParams function

* go.mod
vishal-kanna and others added 24 commits October 9, 2025 11:59
Introduces pre-upgrade integration tests for v4.1, supporting scripts and environment files, and updates the CI workflow to run and report these tests. Also adjusts upgrade scripts and test logic to support sequential upgrades and corrects proposal IDs for v4.2.
Copy link
Member

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final signoff is on point!

Approved 👍.

@Eengineer1 Eengineer1 changed the title feat: implement oracle module feat: Oracle module (SMA, WMA, EMA) Nov 3, 2025
@Eengineer1 Eengineer1 merged commit c330402 into develop Nov 4, 2025
37 of 39 checks passed
@Eengineer1 Eengineer1 deleted the vishal/oracle branch November 4, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants