Feature/function6d #478
Merged
Feature/function6d #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derived from Raysect's Function3D
jacklovell
reviewed
Mar 4, 2025
Member
jacklovell
left a comment
jacklovell
left a comment
There was a problem hiding this comment.
This looks really good. Barring a couple of minor cosmetic changes, I think it's good to go.
Reason for having Function6D in Cherab was removed
jacklovell
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Function6Dframework inspired by Raysect'sFunction3D. The reason for having it in Cherab is that it is domain specific due to its relation toDistributionFunction, as discussed in #477.The contribution is derived from Raysect's framework and the PR by @munechika-koyo.