refactor: hpm eeprom emulation -> fal+flashdb #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e options, so force to -O2
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request updates several build configurations, linker scripts, and source files across the HSLinkPro project. It modifies CMake workflows, integrates new third‐party components via submodules, and replaces EEPROM-based settings with flash database and JSON‐based settings management. Memory layout adjustments for the bootloader and flash abstraction layer changes are included, along with updates to LED control (WS2812) timing and power voltage renaming. Various board initialization functions and logging configurations have been updated to reflect these design shifts. Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application
participant LED as WS2812 LED Controller
App->>LED: HSP_WS2812_SetColor(r, g, b)
LED->>LED: Check if neopixel is initialized
alt Initialized
LED-->>LED: Set color components and flush update
else Not Initialized
LED-->>App: (No action/log warning)
end
sequenceDiagram
participant User as User
participant Settings as Setting Module
participant KV as Key-Value Store
participant HW as Hardware
User->>Settings: Setting_Init()
Settings->>KV: load_settings()
alt Settings Found
KV-->>Settings: Return settings
else Not Found
Settings-->>Settings: Use default settings
Settings->>KV: store_settings(default)
end
Settings->>HW: update_settings()
Note over Settings, HW: Hardware configuration updated
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (26)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Refactor