Skip to content

ehci: update config to improve performance#295

Merged
sakumisu merged 1 commit intocherry-embedded:masterfrom
chenzhihong007:master
Mar 28, 2025
Merged

ehci: update config to improve performance#295
sakumisu merged 1 commit intocherry-embedded:masterfrom
chenzhihong007:master

Conversation

@chenzhihong007
Copy link
Contributor

@chenzhihong007 chenzhihong007 commented Mar 12, 2025

  • update config to improve performance

Summary by CodeRabbit

  • Refactor
    • Enhanced the USB host controller's initialization process. The update preserves current hardware settings and fine-tunes configuration parameters to improve overall stability and adaptability across different system environments.

@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2025

Walkthrough

The pull request updates the usb_hc_init function in the USB host controller module. Instead of initializing the regval variable to zero, it now reads the current register value from EHCI_HCOR->usbcmd. Specific bits corresponding to the interrupt threshold and frame list size are cleared using bitwise operations. Furthermore, a conditionally applied setting for the interrupt threshold is introduced based on the CONFIG_USB_EHCI_HPMICRO definition, ensuring the register configuration accounts for diverse hardware settings.

Changes

File(s) Change Summary
port/.../usb_hc_ehci.c In usb_hc_init, regval is now set to the current command register value instead of zero. Cleared specific bits using masks and conditionally set EHCI_USBCMD_ITHRE_1MF if CONFIG_USB_EHCI_HPMICRO is defined.

Sequence Diagram(s)

sequenceDiagram
    participant INIT as usb_hc_init
    participant REG as EHCI_HCOR
    INIT->>REG: Read current usbcmd value
    INIT->>INIT: Clear EHCI_USBCMD_ITHRE_MASK & EHCI_USBCMD_FLSIZE_MASK bits
    alt CONFIG_USB_EHCI_HPMICRO defined
        INIT->>INIT: Set EHCI_USBCMD_ITHRE_1MF bit conditionally
    end
    INIT->>REG: Write updated regval back
Loading

Poem

I'm a rabbit, hopping through the code,
Updating bits on a winding road.
From zero to the current state,
With conditionals that oscillate.
I nibble bugs, set bits with glee,
Celebrating changes in harmony!
🐇✨

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c64bc7 and c7c8ae3.

📒 Files selected for processing (1)
  • port/ehci/usb_hc_ehci.c (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • port/ehci/usb_hc_ehci.c

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

- update config to improve performance

Signed-off-by: Zhihong Chen <zhihong.chen@hpmicro.com>
@sakumisu sakumisu merged commit d9c0d27 into cherry-embedded:master Mar 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments