fix:(port/ch58x/usb_ch58x_dc_usbfs.c) fix out endpoint cannot receive…

[FanhuaCloud]

… bug

Summary by CodeRabbit

• Bug Fixes
  • Improved USB OUT token interrupt handling to ensure more reliable endpoint communication.

[coderabbitai]

Walkthrough

The update changes the sequence in which the RX NAK state is set during USB OUT token interrupt handling in the USBD_IRQHandler function. The RX NAK is now set after toggling the endpoint control register for endpoints 0 and 4, instead of before.

Changes

File(s)	Change Summary
port/ch32/ch58x/usb_ch58x_dc_usbfs.c	Moved the call to set RX NAK (EPn_SET_RX_NAK) after endpoint toggle in OUT token interrupt handling for endpoints 0 and 4. No other logic was changed.

Sequence Diagram(s)

sequenceDiagram
    participant USB_Device
    participant USBD_IRQHandler
    participant Endpoint_0
    participant Endpoint_4

    USB_Device->>USBD_IRQHandler: OUT token interrupt
    USBD_IRQHandler->>Endpoint_0: Toggle endpoint control register (if ep 0)
    USBD_IRQHandler->>Endpoint_0: Set RX NAK (if ep 0)
    USBD_IRQHandler->>Endpoint_4: Toggle endpoint control register (if ep 4)
    USBD_IRQHandler->>Endpoint_4: Set RX NAK (if ep 4)

Loading

Possibly related PRs

• cherry-embedded/CherryUSB#290: Modifies TX length setting in USB IN token handling, affecting a different part of the same interrupt handler function but related to token direction and endpoint operations.

Poem

A hop and a skip, a toggle anew,
The RX NAK now waits its cue.
Endpoints dance in tidy array,
After a flip, NAK comes to play.
USB flows with careful might—
CodeRabbit keeps it running right!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53e42e6 and 670a191.

📒 Files selected for processing (1)

• port/ch32/ch58x/usb_ch58x_dc_usbfs.c (3 hunks)

🔇 Additional comments (2)

port/ch32/ch58x/usb_ch58x_dc_usbfs.c (2)

546-560: LGTM: Critical timing fix for endpoint 0 OUT handling.

The reordering of EPn_SET_RX_NAK(epid) to occur after the toggle operation (CH58x_USBFS_DEV->UEP0_CTRL ^= RB_UEP_R_TOG) is correct and addresses a USB protocol compliance issue. The toggle bit must be updated first to reflect successful packet reception before setting the endpoint to NAK state to prevent data toggle synchronization problems.

---

561-582: LGTM: Critical timing fix for endpoint 4 OUT handling.

Similar to endpoint 0, moving EPn_SET_RX_NAK(epid) after the toggle operation (CH58x_USBFS_DEV->UEP4_CTRL ^= RB_UEP_R_TOG) ensures proper USB data toggle synchronization. This fix prevents the OUT endpoint reception issues mentioned in the PR objectives.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.