New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CherryPy wsgiserver should reject conns when Queue.Full #1301

Closed
bb-migration opened this Issue Mar 13, 2014 · 7 comments

Comments

Projects
None yet
1 participant
@bb-migration

bb-migration commented Mar 13, 2014

Originally reported by: Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco)


In 49b22a7, CherryPy 3.0 was updated to reject connections when Queue.Full. This change did not make it into 3.2.x. It should be ported forward.


@bb-migration

This comment has been minimized.

Show comment
Hide comment
@bb-migration

bb-migration Mar 13, 2014

Original comment by Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco):


Porting forward look challenging. The codebase has changed a lot. Also, the new server object has attributes that may or may not be related. For instance, Server.socket_timeout, Server.socket_queue_size, and Server.thread_pool_max seem related. However, there doesn't appear to be any handling of Queue.Full.

@Fumanchu Do you have any hints about what is the right thing to do here?

bb-migration commented Mar 13, 2014

Original comment by Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco):


Porting forward look challenging. The codebase has changed a lot. Also, the new server object has attributes that may or may not be related. For instance, Server.socket_timeout, Server.socket_queue_size, and Server.thread_pool_max seem related. However, there doesn't appear to be any handling of Queue.Full.

@Fumanchu Do you have any hints about what is the right thing to do here?

@bb-migration

This comment has been minimized.

Show comment
Hide comment
@bb-migration

bb-migration Jun 13, 2014

Original comment by Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco):


I'd like to offer a $200 bounty to implement a robust fix for this issue if implemented against CherryPy 3.2.x.

bb-migration commented Jun 13, 2014

Original comment by Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco):


I'd like to offer a $200 bounty to implement a robust fix for this issue if implemented against CherryPy 3.2.x.

@bb-migration

This comment has been minimized.

Show comment
Hide comment
@bb-migration

bb-migration Jun 13, 2014

Original comment by James Rydberg (Bitbucket: jamesrydberg, GitHub: jamesrydberg):


bb-migration commented Jun 13, 2014

Original comment by James Rydberg (Bitbucket: jamesrydberg, GitHub: jamesrydberg):


@bb-migration

This comment has been minimized.

Show comment
Hide comment
@bb-migration

bb-migration Jun 14, 2014

Original comment by Allan Crooks (Bitbucket: the_allanc, GitHub: Unknown):


Reimplementation of code to allow bounded request queues - rejecting requests when the queue is full. Fixes #1301.

bb-migration commented Jun 14, 2014

Original comment by Allan Crooks (Bitbucket: the_allanc, GitHub: Unknown):


Reimplementation of code to allow bounded request queues - rejecting requests when the queue is full. Fixes #1301.

@bb-migration

This comment has been minimized.

Show comment
Hide comment
@bb-migration

bb-migration Jun 14, 2014

Original comment by Allan Crooks (Bitbucket: the_allanc, GitHub: Unknown):


I've tested this with Python 2 and 3, and appears to work. I've branched this off the CP3.3 development branch, but it can be easily transplanted against CP3.2.

bb-migration commented Jun 14, 2014

Original comment by Allan Crooks (Bitbucket: the_allanc, GitHub: Unknown):


I've tested this with Python 2 and 3, and appears to work. I've branched this off the CP3.3 development branch, but it can be easily transplanted against CP3.2.

@bb-migration

This comment has been minimized.

Show comment
Hide comment
@bb-migration

bb-migration Jun 27, 2014

Original comment by Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco):


woo! Would you like bitcoin or paypal?

bb-migration commented Jun 27, 2014

Original comment by Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco):


woo! Would you like bitcoin or paypal?

@bb-migration

This comment has been minimized.

Show comment
Hide comment
@bb-migration

bb-migration Aug 17, 2014

Original comment by Gustavo Picon (Bitbucket: tabo, GitHub: tabo):


Reimplementation of code to allow bounded request queues - rejecting requests when the queue is full. Fixes #1301.

bb-migration commented Aug 17, 2014

Original comment by Gustavo Picon (Bitbucket: tabo, GitHub: tabo):


Reimplementation of code to allow bounded request queues - rejecting requests when the queue is full. Fixes #1301.

jaraco pushed a commit that referenced this issue Apr 30, 2016

Reimplementation of code to allow bounded request queues - rejecting …
…requests when the queue is full. Fixes #1301.

--HG--
branch : 1301-reject-conns-when-full

jaraco pushed a commit that referenced this issue Apr 30, 2016

Reimplementation of code to allow bounded request queues - rejecting …
…requests when the queue is full. Fixes #1301.

--HG--
branch : cp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment