Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "publish should be called when the state is changed" #1774

Merged
merged 4 commits into from Mar 27, 2019

Conversation

Projects
None yet
1 participant
@jaraco
Copy link
Member

commented Mar 26, 2019

This reverts commit 20bc9db.

What kind of change does this PR introduce?

  • bug fix
  • feature
  • docs update
  • tests/coverage improvement
  • refactoring
  • other

What is the related issue number (starting with #)

#1759

What is the current behavior? (You can also link to an open issue here)

'main' event doesn't fire periodically on the bus

What is the new behavior (if this is a feature change)?

'main' event fires 10x per second

Other information:

Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

@jaraco jaraco closed this Mar 27, 2019

@jaraco jaraco reopened this Mar 27, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 27, 2019

Codecov Report

Merging #1774 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1774      +/-   ##
=========================================
- Coverage   80.99%   80.9%   -0.09%     
=========================================
  Files         104     104              
  Lines       13643   13643              
=========================================
- Hits        11050   11038      -12     
- Misses       2593    2605      +12

@jaraco jaraco force-pushed the bugfix/1759-revert branch from fbe38ed to cda7b7f Mar 27, 2019

@jaraco

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

Now that we know this behavior was by design, I'd really like to have a test that captures the desired behavior (that 'main' is invoked periodically).

@jaraco jaraco merged commit 5d2b025 into master Mar 27, 2019

2 of 7 checks passed

LGTM analysis: Python Running analyses for revisions
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
LGTM analysis: JavaScript No code changes detected
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@jaraco jaraco deleted the bugfix/1759-revert branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.