Revert "publish should be called when the state is changed"#1774
Merged
Revert "publish should be called when the state is changed"#1774
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1774 +/- ##
=========================================
- Coverage 80.99% 80.9% -0.09%
=========================================
Files 104 104
Lines 13643 13643
=========================================
- Hits 11050 11038 -12
- Misses 2593 2605 +12 |
This reverts commit 20bc9db.
fbe38ed to
cda7b7f
Compare
Member
Author
|
Now that we know this behavior was by design, I'd really like to have a test that captures the desired behavior (that 'main' is invoked periodically). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 20bc9db.
What kind of change does this PR introduce?
What is the related issue number (starting with
#)#1759
What is the current behavior? (You can also link to an open issue here)
'main' event doesn't fire periodically on the bus
What is the new behavior (if this is a feature change)?
'main' event fires 10x per second
Other information:
Checklist:
and description in grammatically correct, complete sentences