Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Emit all errors in hooks #1806
What kind of change does this PR introduce?
What is the related issue number (starting with
This alternative implementation is based on the one I proposed in #1771. It uses recursion and the exception handling inherent to Python to emit multiple tracebacks. This works because
@@ Coverage Diff @@ ## master #1806 +/- ## ========================================== - Coverage 80.68% 79.95% -0.74% ========================================== Files 104 104 Lines 13245 13246 +1 ========================================== - Hits 10687 10591 -96 - Misses 2558 2655 +97
Right, so I see
I created this repro, which if run on master, produces:
whereas with the patch applied, the result includes both exceptions that occurred:
I believe this effectively demonstrates the effectiveness of the change.
Because this relies on Python 3 to achieve its ends, I'm not going to attempt to back port this to 17.x, although I welcome others to try.