Skip to content

Do not skip an inaccessible database at agent startup#46

Merged
cherts merged 7 commits intocherts:masterfrom
dbulashev:fix-skipping-unavailable-db
Oct 29, 2024
Merged

Do not skip an inaccessible database at agent startup#46
cherts merged 7 commits intocherts:masterfrom
dbulashev:fix-skipping-unavailable-db

Conversation

@dbulashev
Copy link
Copy Markdown

No description provided.

@cherts
Copy link
Copy Markdown
Owner

cherts commented Oct 21, 2024

I think we should make an additional option, like test_db_connection_on_startup = true
This way, by default, we test the database connection and do not break backward compatibility.
It is probably important for some users to terminate the service if the database is not available.
If we disable this option (test_db_connection_on_startup = false), then pgSCV will start even if the database is not available at startup.

@cherts
Copy link
Copy Markdown
Owner

cherts commented Oct 29, 2024

I made a slight mistake in the logic of checking the connection to the database, the variable is logically called skip_conn_error_mode and by default it will be false

@cherts cherts merged commit 47e69a0 into cherts:master Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants