Implemented shop enhancements #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Impressive work on fleshing out the shop system. |
chessmasterhong
added a commit
that referenced
this pull request
Feb 4, 2015
Implemented shop enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You will need the latest media from https://bitbucket.org/chessmasterhong/wateremblem-media/downloads to run this.
This pull request addresses issue #133. On top of enhancing the shop system, I went ahead and also implemented a confirmation system too. Clicking an item will prompt the player with a
YesorNooption, both for buy and sell. Almost all messages are on a timer, to make it feel a little more real.Also covered cases where the player cannot afford to buy the item in question, or has a full inventory - the appropriate text is displayed on a timer.
EDIT: I've also added some new properties that space out messages in the shop. For example, purchasing an item will:
<item>, then after 1.5 seconds, it will re-display the buy/sell/exit buttons.This behavior occurs for both buying and selling, to add some flow and separation between buying, selling, waiting for the user to press yes/no to confirm their choice, etc. As of now, the shop system fully resembles a shop in an actual Fire Emblem game (or any game with a shop, in general).