New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented shop enhancements #141

Merged
merged 14 commits into from Feb 4, 2015

Conversation

Projects
None yet
2 participants
@DrkSephy
Copy link
Collaborator

DrkSephy commented Feb 4, 2015

You will need the latest media from https://bitbucket.org/chessmasterhong/wateremblem-media/downloads to run this.

This pull request addresses issue #133. On top of enhancing the shop system, I went ahead and also implemented a confirmation system too. Clicking an item will prompt the player with a Yes or No option, both for buy and sell. Almost all messages are on a timer, to make it feel a little more real.
Also covered cases where the player cannot afford to buy the item in question, or has a full inventory - the appropriate text is displayed on a timer.

EDIT: I've also added some new properties that space out messages in the shop. For example, purchasing an item will:

  • Show a message saying you have purchased <item>, then after 1.5 seconds, it will re-display the buy/sell/exit buttons.

This behavior occurs for both buying and selling, to add some flow and separation between buying, selling, waiting for the user to press yes/no to confirm their choice, etc. As of now, the shop system fully resembles a shop in an actual Fire Emblem game (or any game with a shop, in general).

@chessmasterhong

This comment has been minimized.

Copy link
Owner

chessmasterhong commented Feb 4, 2015

Impressive work on fleshing out the shop system.

chessmasterhong added a commit that referenced this pull request Feb 4, 2015

Merge pull request #141 from DrkSephy/dev
Implemented shop enhancements

@chessmasterhong chessmasterhong merged commit c7298cf into chessmasterhong:dev Feb 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment