Update jvc-convert of KB layout Hsu#259
Merged
czchen merged 1 commit intochewing:masterfrom May 6, 2017
Merged
Conversation
* src/bopomofo.c Bopomofo ㄐㄑㄒ always come with ㄧ or ㄩ, if not, libchewing should convert them to ㄓㄔㄕ, and vice versa. But currently libchewing doesn't do the ㄓㄔㄕ to ㄐㄑㄒ convertion. This commit add it. Moreover, since ㄐㄑㄒ cannot exist alone, when users press jvc keys, libchewing should send ㄓㄔㄕ into buffer as default, and convert them to ㄐㄑㄒ after users press ㄧㄩ. * test/test-bopomofo.c update test cases for KB layout Hsu.
Member
|
Thanks for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
增補ㄓㄔㄕ→ㄐㄑㄒ轉換。
許氏的ㄐㄑㄒ和ㄓㄔㄕ是在同一個按鍵，有介音ㄧ或ㄩ的時候，ㄓㄔㄕ才會轉換成ㄐㄑㄒ。但目前 libchewing 只有ㄐㄑㄒ轉ㄓㄔㄕ，沒有ㄓㄔㄕ轉ㄐㄑㄒ。因此，若使用者先輸入韻母才輸入介音，就無法正確的出字。例如：使用者想輸入「鄉」，但在快速打字的時候出錯，順序變成
ㄒ → ㄤ → 一，這時ㄒ會因為ㄤ而轉換成ㄕ，等到輸入ㄧ的時候卻沒有再換回ㄒ，變成ㄕㄧㄤ。[1]按下 jvc 時，優先輸出ㄓㄔㄕ。
ㄓㄔㄕ本身加聲調就可以出字，而ㄐㄑㄒ不行。但目前 libchewing 是按下 jvc 鍵時先輸出ㄐㄑㄒ到預編區，等按聲調的時候才轉換成ㄓㄔㄕ，所以使用者看見的是輸入ㄐ卻得到ㄓ的字（之、知、隻等等），這樣比較不直覺，也和自然輸入法的行為相反，所以改為先輸出ㄓㄔㄕ。
更新 test case。
[1] https://groups.google.com/d/msg/chewing-devel/D8MMq_sRxnU/KZ3ucglaAAAJ