Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=========================================
+ Coverage 64.3% 66.4% +2.09%
=========================================
Files 11 11
Lines 1496 1518 +22
Branches 166 167 +1
=========================================
+ Hits 962 1008 +46
+ Misses 482 458 -24
Partials 52 52 |
The suggested optimization is actually not good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewrites the
add_with_carry()foruint128to a bit more efficient form (easier to consume by compilers).Also subtraction is implemented in the analogous way to additions, instead of reusing addition.
GCC9:
Clang9: