Fix udivrem dead branch causing static analysis failures #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `udivrem` with divisor being `uint128` (2 words) the Knuth division branch is dead because it handles divisors with more than 2 words. However, the compiler or static analyzer will compile this branch and report array out-of-bounds access (e.g. GCC-15, Clang Analyzer 21). Fix this by adding more hints about expected value ranges.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
udivremwith divisor beinguint128(2 words) the Knuth division branch is dead because it handles divisors with more than 2 words.However, the compiler or static analyzer will compile this branch and report array out-of-bounds access (e.g. GCC-15, Clang Analyzer 21).
Fix this by adding more hints about expected value ranges.