fix(build): make release artifacts deterministic#250
Merged
Conversation
Deploying podnotes with
|
| Latest commit: |
fa5cfc3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd345423.podnotes.pages.dev |
| Branch Preview URL: | https://chore-harden-build-artifacts.podnotes.pages.dev |
chhoumann
marked this pull request as ready for review
July 9, 2026 20:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build/so production builds cannot follow a development symlinkmain.jsas a regular root file while retaining root symlinks for development buildsWhy
The previous production output directory was the repository root. If
main.jswas already the development symlink tobuild/main.js, a production build followed that symlink, so artifact topology depended on checkout history. Releases still consume rootmain.js; this change makes that artifact deterministic without changing the release or E2E contract.Verification
main.jsis a regular file and rootmain.js.mapis absentmain.jsandmain.js.mapsymlinks6f593e89c049bc84a8a9b3da90a5f002ccc5b8e1066ae05aef671dbc12cd5ebcValidation
npm run lintnpm run format:checknpm run typechecknpm run buildnpm run test- 70 files, 883 testsdocs/requirements.txtgit diff --checkRelease impact
Root
main.jsremains the release and attestation asset. No consumer path changes are required.