test(e2e): add file collision behavior coverage#1153
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds end-to-end testing: Vitest E2E config, an extensive E2E test exercising QuickAdd file-existence behaviors and migrations, a package script and devDependency for E2E, README development instructions, and .gitignore updates to ignore Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as Test Runner
participant Sandbox as Obsidian Sandbox
participant Plugin as QuickAdd Plugin
participant FileSystem as File System
Runner->>Sandbox: Initialize E2E vault
Runner->>Sandbox: Acquire vault run lock
Runner->>FileSystem: Seed template files
Runner->>Plugin: Trigger QuickAdd choice (T01–T15 / M1–M6)
Plugin->>FileSystem: Create/modify files per behavior
Runner->>Runner: Poll for results / assertions
Runner->>Sandbox: Capture failure artifacts if needed
Runner->>Sandbox: Release vault lock & cleanup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying quickadd with
|
| Latest commit: |
e626b3b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e89c5e2b.quickadd.pages.dev |
| Branch Preview URL: | https://test-e2e-file-collision-beha.quickadd.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95aff614da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add Obsidian-backed end-to-end coverage for template file collision behavior.
This adds a dedicated
bun run test:e2eentrypoint usingobsidian-e2e, a live-vault suite that exercises the file collision behavior matrix and the file-exists migration path against a real QuickAdd plugin instance. It also documents the local E2E workflow in the repo README and ignores captured failure artifacts.I considered wiring the suite into the existing GitHub Actions test job, but these tests currently depend on a locally installed Obsidian app, the
obsidianCLI onPATH, and an opendevvault. Keeping them as an explicit local suite makes that dependency clear while still giving us verifiable coverage for the regression space around #1139.Reviewer context and risk notes:
bun run build-with-lintandbun run test:e2e.Refs #1139
Summary by CodeRabbit
Documentation
Tests
Chores