Skip to content

Fix PWA: startup flash, Add Feed shortcut no-op, and Share Target 404#24

Merged
chiga0 merged 3 commits intomainfrom
copilot/fix-pwa-mode-bugs
Mar 4, 2026
Merged

Fix PWA: startup flash, Add Feed shortcut no-op, and Share Target 404#24
chiga0 merged 3 commits intomainfrom
copilot/fix-pwa-mode-bugs

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 4, 2026

  • Fix startup flash: add critical inline CSS in index.html for #app-loading screen
  • Fix "Add Feed" shortcut: FeedsPage reads ?action=add-feed and opens dialog
  • Fix share target "page not found": change manifest to GET, handle params in FeedsPage
  • Fix E2E: favorites.spec.ts - use exact-match regex (^Favorite$/^收藏$) so "Favorited" isn't matched; handle pre-favorited state by unfavoriting first; increase post-click timeout from 5s→10s
  • Fix E2E: history.spec.ts - wait for .animate-spin to disappear (IndexedDB loads after networkidle); increase article visibility timeout 10s→15s
  • Fix E2E: feedSubscription.spec.ts - wait directly for h1 matching Feeds|订阅源 instead of relying on networkidle + generic first h1; increase timeout 10s→15s
  • All 245 unit tests pass

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 4, 2026

Deploy Preview for rss-reader-pwa ready!

Name Link
🔨 Latest commit 29e31dd
🔍 Latest deploy log https://app.netlify.com/projects/rss-reader-pwa/deploys/69a853c2207f74000893367f
😎 Deploy Preview https://deploy-preview-24--rss-reader-pwa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…arget

Co-authored-by: chiga0 <24784430+chiga0@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix bugs in PWA mode for mobile app Fix PWA: startup flash, Add Feed shortcut no-op, and Share Target 404 Mar 4, 2026
@chiga0
Copy link
Copy Markdown
Owner

chiga0 commented Mar 4, 2026

@copilot 修复自动化测试错误

… heading

Co-authored-by: chiga0 <24784430+chiga0@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 4, 2026

@copilot 修复自动化测试错误

Fixed in commit 29e31dd. Three E2E test issues addressed:

  1. favorites.spec.ts (consistent failure): The regex /Favorite|收藏|favorite/ matched "Favorited" too, so if the article was already favorited from a prior sequential test run, the click would un-favorite it and the "Favorited" assertion would never be satisfied. Fixed by using exact-match anchors (/^Favorite$|^收藏$/ vs /^Favorited$|^已收藏$/), adding a pre-check to unfavorite first if needed, and increasing the post-click timeout from 5s to 10s.

  2. history.spec.ts (flaky): waitForLoadState('networkidle') resolved before the IndexedDB-backed history finished rendering. Fixed by also waiting for the .animate-spin loading indicator to disappear, and increasing article visibility timeout from 10s to 15s.

  3. feedSubscription.spec.ts (flaky): After clicking "Back to Feeds", asserting the generic first h1 after networkidle could race with the page transition. Fixed by waiting directly for h1 with text matching Feeds|订阅源 (timeout 15s), which is self-asserting.

@chiga0 chiga0 marked this pull request as ready for review March 4, 2026 16:23
@chiga0 chiga0 merged commit 37859a5 into main Mar 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants