Skip to content

afero.ReadDir sorts ReadDir entries. Nooooooo! #17

@LandonTClipp

Description

@LandonTClipp
func ReadDir(fs Fs, dirname string) ([]os.FileInfo, error) {
	f, err := fs.Open(dirname)
	if err != nil {
		return nil, err
	}
	list, err := f.Readdir(-1)
	f.Close()
	if err != nil {
		return nil, err
	}
	sort.Sort(byName(list))
	return list, nil
}

This is super bad because it means we are wasting time sorting even if we don't want to. Very bad for large directories, and it means it is non-configurable. Will need to write our own ReadDir.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions