Skip to content

Refactoring API and organizing code#6

Merged
LandonTClipp merged 1 commit intochigopher:masterfrom
LandonTClipp:refactor
Jul 6, 2020
Merged

Refactoring API and organizing code#6
LandonTClipp merged 1 commit intochigopher:masterfrom
LandonTClipp:refactor

Conversation

@LandonTClipp
Copy link
Copy Markdown
Contributor

Two things are being done here:

  1. The code is being refactored to be a very thin layer around the
    underlying filesystems, and to match their API as close as possible.
  2. Organizing the code to make my design philosophy more clear and
    concise.

@LandonTClipp
Copy link
Copy Markdown
Contributor Author

LandonTClipp commented Jul 2, 2020

Make RelativeTo return non-nil object on errors.

Also, ensure the error message makes sense when RelativeTo breaks because of bad arguments.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 6, 2020

Codecov Report

Merging #6 into master will increase coverage by 0.67%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   60.00%   60.67%   +0.67%     
==========================================
  Files           1        1              
  Lines         170      178       +8     
==========================================
+ Hits          102      108       +6     
- Misses         56       63       +7     
+ Partials       12        7       -5     
Impacted Files Coverage Δ
path.go 60.67% <71.42%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fc246...4ad2575. Read the comment docs.

Two things are being done here:

1. The code is being refactored to be a very thin layer around the
   underlying filesystems, and to match their API as close as possible.
2. Organizing the code to make my design philosophy more clear and
   concise.
@LandonTClipp LandonTClipp merged commit ee25600 into chigopher:master Jul 6, 2020
@LandonTClipp LandonTClipp deleted the refactor branch July 6, 2020 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant