Refactoring API and organizing code#6
Merged
LandonTClipp merged 1 commit intochigopher:masterfrom Jul 6, 2020
Merged
Conversation
Contributor
Author
|
Make RelativeTo return non-nil object on errors. Also, ensure the error message makes sense when RelativeTo breaks because of bad arguments. |
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 60.00% 60.67% +0.67%
==========================================
Files 1 1
Lines 170 178 +8
==========================================
+ Hits 102 108 +6
- Misses 56 63 +7
+ Partials 12 7 -5
Continue to review full report at Codecov.
|
Two things are being done here: 1. The code is being refactored to be a very thin layer around the underlying filesystems, and to match their API as close as possible. 2. Organizing the code to make my design philosophy more clear and concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things are being done here:
underlying filesystems, and to match their API as close as possible.
concise.