Skip to content

rf: Encapsulate BIDS schema loading and thread through indexer#71

Closed
effigies wants to merge 21 commits into
childmindresearch:mainfrom
effigies:rf/bids-schema-encapsulation
Closed

rf: Encapsulate BIDS schema loading and thread through indexer#71
effigies wants to merge 21 commits into
childmindresearch:mainfrom
effigies:rf/bids-schema-encapsulation

Conversation

@effigies
Copy link
Copy Markdown
Contributor

@effigies effigies commented Apr 30, 2026

I have not had a detailed read-through, but I want to get this up here. Please feel free to ignore while in draft state, but thoughts are welcome before then, for the motivated.

Disclosure: I had a detailed discussion with Claude to develop the plan, but the implementation was 100% Claude as of 1f9aa7e.

Closes #70.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 96.84211% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.11%. Comparing base (c1d67b2) to head (473dd54).

Files with missing lines Patch % Lines
bids2table/_schema.py 95.16% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   95.15%   95.11%   -0.04%     
==========================================
  Files           7        8       +1     
  Lines         495      532      +37     
==========================================
+ Hits          471      506      +35     
- Misses         24       26       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies effigies force-pushed the rf/bids-schema-encapsulation branch from 1f9aa7e to 8379a5d Compare April 30, 2026 11:15
@effigies effigies force-pushed the rf/bids-schema-encapsulation branch from 115e888 to d3352c3 Compare April 30, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace global schema state with schema adapter dataclass

1 participant