Single subject anatomical workflow#35
Conversation
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (29.50%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
============================================
- Coverage 100.00% 29.50% -70.50%
============================================
Files 1 7 +6
Lines 10 61 +51
============================================
+ Hits 10 18 +8
- Misses 0 43 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0e9f0c2 to
72cc479
Compare
| uses: ./.github/actions/setup-venv | ||
| - name: Run quick tests | ||
| id: run-quick-tests | ||
| shell: bash |
There was a problem hiding this comment.
You would think so, but without it the windows runs fail.
There was a problem hiding this comment.
ah because of the linebreaks with \
There was a problem hiding this comment.
switching to no linebreaks is probably better than emulating bash on windows
There was a problem hiding this comment.
or alternatively run just pytest without coverage there - dont think we need multi platform cov
There was a problem hiding this comment.
yeah i think i'll probably address this workflow in a separate PR. At least for now this works and gives us some tests, but definitely want to change it up.
- Add 'shell: bash' for cross platform
- Rename skull_stripping.py -> segmentation.py - Added FSL Fast segmentation to anatomical workflow
|
This one is pretty much good to go from a workflow standpoint (will add tests in a separate PR just to get this pushed in for now). I am just waiting for the local e2e test to finish. |
|
Also just updated the dependencies in a separate commit (for easy rollback) to satisfy the |
|
Merging for now to be able to base other PRs testing on this structure - subsequent PRs should improve CI and documentation |
Duplicate of #6, that got closed automatically when trying to fix lfs (and couldn't reopen).
First implementation of workflow with modular pieces of RBC anatomical / structural.
cc: @jpillai00