fix(helm): follow directory symlinks when hashing charts#39
Merged
Conversation
sumFiles previously skipped directory symlinks, leaving the chart hash blind to content changes inside the symlink target. The new walker enqueues each directory symlink as a fresh filepath.Walk job with cycle detection on resolved real paths and a hard error on broken symlinks. Hash keys remain the as-seen path so existing exact-hash regression tests stay valid. Fixes chime#35 Assisted-by: Opus 4.7 via Claude Code
v-yarotsky
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sumFilesskipped any directory symlink it encountered, so charts that share content via symlinked directories had cache keys blind to changes inside the symlink target. Reworks the walker to descend through directory symlinks while keeping behavior for symlink-free charts byte-identical.Non-obvious context
GenerateHashOnChart,GenerateHash) stay valid and downstream stored hashes for symlink-free charts don't roll.Tests
New
TestHelmsub-tests cover dir-symlink follow, cycle (loop -> .), and broken-symlink error. Pre-existing exact-hash tests act as the regression gate for symlink-free input.Fixes #35
Assisted-by: Opus 4.7 via Claude Code