user/nilfs-utils: update to 2.2.12, fix mount helper option parsing #4923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NILFS2 mount helpers rely on GNU behaviour of getopt to parse options correctly when invoked by mount. With posix getopt they silently ignore mount options.
nilfsuser5678
force-pushed
the
nilfs-utils-2.2.12
branch
from
b2794ba to
8ebff53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The NILFS2 mount helpers rely on GNU behaviour of getopt to parse
options correctly when invoked by mount. With posix getopt they silently
ignore mount options because mount from util-linux invokes helpers with
non-option arguments before option arguments which posix getopt then
ignores. This fixes it by linking the gnu-getopt compat package. It
could also be fixed by patching getopt_long in place of getopt.
Checklist
Before this pull request is reviewed, certain conditions must be met.
The following must be true for all changes:
The following must be true for template/package changes:
The following must be true for new package submissions: