Add : fibonacci.py, search.py [DFS and BFS] #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adikul30
changed the title
chiphuyen
reviewed
Oct 7, 2019
| def test(): | ||
| fibonacci(5) | ||
|
|
||
| test() No newline at end of file |
Owner
There was a problem hiding this comment.
Thank you so much for your merge request. There are a couple of comments:
- performance: this isn't a very efficient way to calculate the fibonacci since we'll have to calculate each element multiple times. You might want to use memoization. See more here: https://stackoverflow.com/a/18172463
- style: please use spaces instead of tabs, since tabs get converted weirdly on GitHub.
chiphuyen
reviewed
Oct 7, 2019
| visited = [] | ||
| bfs(1) | ||
|
|
||
| test() No newline at end of file |
Owner
There was a problem hiding this comment.
Please follow PEP8 style guide!
chiphuyen
reviewed
Oct 7, 2019
| q = queue.Queue(MAX) | ||
|
|
||
| def dfs(s): | ||
| if s in visited : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.