Skip to content

fix: handle zero runtime dependencies in CI #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiply merged 1 commit into from
Feb 19, 2026
Merged

fix: handle zero runtime dependencies in CI #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- uses: emacs-eask/setup-eask@master
with:
version: 'snapshot'
- run: eask install-deps
- run: eask install-deps || true
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using || true will hide all eask install-deps failures (e.g., network issues, registry outages, or a newly added dependency that fails to resolve), which reduces CI’s ability to catch real problems. Consider only allowing the specific “no runtime dependencies” exit code (e.g., eask install-deps || [ $? -eq 2 ]), so other non-zero exit codes still fail the job.

Suggested change
- run: eask install-deps || true
- run: eask install-deps || [ $? -eq 2 ]

Copilot uses AI. Check for mistakes.
- run: eask compile
- run: eask lint package
continue-on-error: true
Expand Down