fix: use release-please extra-files for version updates#5
Conversation
…merge Move version management into release-please's release PR by adding extra-files with x-release-please-version markers in space-tree.el and Eask. This ensures the release tag includes the correct version numbers. Remove the post-release sed steps and auto-merge workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR modernizes the release workflow to use release-please's built-in extra-files feature for version management. Instead of updating version strings in space-tree.el and Eask after a release is created, release-please now updates all version strings (including version.txt, space-tree.el, and Eask) directly in the release PR itself. The PR also removes the auto-merge workflow to allow for review feedback before merging.
Changes:
- Configure release-please to update
space-tree.elandEaskversions using theextra-filesfeature - Add
x-release-please-versionmarkers to guide version string updates - Remove post-release version update steps from the release workflow (no longer needed)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| release-please-config.json | Adds extra-files configuration for space-tree.el and Eask with generic updater type |
| space-tree.el | Adds x-release-please-version marker to the Version header comment |
| Eask | Adds x-release-please-version marker to the version string |
| .github/workflows/release.yml | Removes post-release sed steps and commit logic (superseded by extra-files) |
| .github/workflows/auto-merge.yml | Deleted to disable automatic PR approval and merging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Eask
Outdated
|
|
||
| (package "space-tree" | ||
| "0.1.0" | ||
| "0.1.0" ; x-release-please-version |
There was a problem hiding this comment.
The comment syntax for the release-please version marker is inconsistent between files. In space-tree.el, the marker uses double semicolons (;;) which is the Emacs Lisp comment style, while in Eask, it uses a single semicolon (;). For consistency and to ensure release-please's generic updater processes both files correctly, both markers should use the same comment format. Since Eask files also use Emacs Lisp syntax, consider using double semicolons in both files.
| "0.1.0" ; x-release-please-version | |
| "0.1.0" ;; x-release-please-version |
The inline x-release-please-version marker was included in the version string parsed by Eask. Switch to start/end block markers on separate comment lines instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add windows-latest and Emacs 30.2 to the CI matrix: - OS: ubuntu-latest, macos-latest, windows-latest - Emacs: 29.4 (min supported line), 30.2 (current stable), snapshot Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The code only requires string-split (introduced in 28.1). Lower the declared minimum from 29.1 to 28.1 in Package-Requires and Eask, and add 28.2 to the CI test matrix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
In Emacs 28, mapconcat requires the SEPARATOR argument (it became optional in Emacs 29). Add explicit "" separator. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add concurrency group to cancel stale runs on new pushes - Split lint (package-lint, checkdoc) into a separate single job - Cache Nix store via magic-nix-cache-action for faster Emacs setup - Cache .eask directory to skip redundant dependency downloads Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pure Elisp package — macOS behavior is identical to Linux. Removes the slowest jobs (74-115s setup overhead on ARM runners). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
extra-filestorelease-please-config.jsonso release-please updatesspace-tree.elandEaskversion strings directly in the release PRx-release-please-versionmarkers tospace-tree.elandEaskso the generic updater knows which lines to modifyrelease.yml— no longer needed since versions are updated in the PR itselfauto-merge.yml— turning off auto-approval to allow acting on review feedback before mergingTest plan
version.txt,space-tree.el, andEasktogether🤖 Generated with Claude Code