Add multi-port switch with learning and flooding#5
Draft
chiroptical wants to merge 1 commit into
Draft
Conversation
chiroptical
force-pushed
the
add_multiport_switch
branch
from
8165d99 to
a9839ac
Compare
chiroptical
commented
May 29, 2026
| ?assertEqual([~"hello world"], TwoBuffer). | ||
|
|
||
| init_per_suite(Config) -> | ||
| {ok, _} = application:ensure_all_started(hauntstack), |
Owner
Author
There was a problem hiding this comment.
One nice thing here is that now my CI checks will know when hauntstack can no longer boot. In theory, I should test everything but even if I didn't this will help protect me a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question: should we allow network endpoints to speak non-ethernet? I'll need to be able to pull out src MAC addresses for learning. This means NICs will also need to speak ethernet. A one-way door for sure. I suppose the binary encoding/decoding doesn't really need to be full ethernet compliant? It only needs to carry the source MAC and payload to work. As we build more functionality it will need more nuance.
Question: How do we know destination MACs when sending messages from a NIC? Is this ARP? I don't think we need ARP yet and we can just do MAC learning and flooding.