Feature/pr #13
Merged
Feature/pr #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| For sound input you will need a digital MEMS microphone such as the SPH0645 or ICS-43434. (Not necessary for the Nano 33 Sense as it comes with an on board microphone) | ||
| For sound output it is recommended to use a digital I2S output such as the UDA1334A or MAX98357A connected to a compatible speaker. | ||
| For receiving data, you will need a digital MEMS microphone. Some boards (for example, the Nano 33 Sense and Microsoft MXChip) already include a MEMS mic so you are good to go. For others, you will need an external mic such as the [SPH0645](https://www.adafruit.com/product/3421) or [ICS-43434](https://www.mouser.co.uk/ProductDetail/TDK-InvenSense/ICS-43434?qs=u4fy%2FsgLU9PAgmWRI7%252BqXA%3D%3D). |
Contributor
There was a problem hiding this comment.
About the second microphone, do we really want to suggest people a microphone no even mounted on a small board ?
Contributor
There was a problem hiding this comment.
Only tested with SPH0645, but other people have suggested ICS as an alternative
Contributor
There was a problem hiding this comment.
I'm not against but the link suggest a microphone which is not mounted on anything :/
| } | ||
|
|
||
| void | ||
| onReceivedCallback(void *chirp, uint8_t *payload, size_t length, uint8_t channel) |
Contributor
There was a problem hiding this comment.
Do we put declarations on one line ?
LittleMonsterFr
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More comments
Consistent use of camelCase 🤢
Slightly more informative variable names