fix: address Copilot review comments#17
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies two small refactors in the terminal renderer and the lines-changed extractor to address prior review feedback, improving naming clarity and import consistency without changing behavior.
Changes:
- Rename
non_fork_repostotop_reposin the lines-changed extractor (repos are already filtered upstream; this is a naming/clarity change). - Move the
Groupimport to the module imports in the terminal renderer and remove the function-local import.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/devcard/renderers/terminal.py |
Imports Group at top-level and removes the local import in _render_lines for consistency. |
src/devcard/extractors/lines.py |
Renames non_fork_repos to top_repos throughout extract_lines_changed for clearer intent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
non_fork_repos→top_reposin lines extractor (forks already filtered upstream)Groupimport to top-level in terminal renderer for consistencyAddresses Copilot review comments on PR #16.
Test plan