Skip to content

chore(charter): absorb ChittyBooks deprecation#118

Closed
chitcommit wants to merge 1 commit into
mainfrom
chore/absorb-chittybooks-deprecation
Closed

chore(charter): absorb ChittyBooks deprecation#118
chitcommit wants to merge 1 commit into
mainfrom
chore/absorb-chittybooks-deprecation

Conversation

@chitcommit
Copy link
Copy Markdown
Contributor

@chitcommit chitcommit commented May 27, 2026

Summary

  • Removes the "ChittyBooks consumes ChittyFinance as engine" line from CHARTER (no longer aspirational — Finance IS the bookkeeping UI after ChittyBooks deprecation)
  • Annotates that ledger writes flow through the ChittyLedger substrate as the Finance projection per the canonical Ledger projection model
  • Updates "Evidence management" reference to the Evidence projection

Context

ChittyBooks was deprecated in CHITTYAPPS/chittybooks#2 after a 2026-05-27 substance audit found both of its unique features (AI categorization + AI insights) already present in ChittyFinance at higher quality.

Source

CHITTYOS/chittymarket docs/remediation/2026-05-27-finance-books-functioning-as-intended.md

Test plan

  • Charter renders cleanly in canon validator
  • No code/contract change — docs only

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated charter documentation to clarify Finance scope boundaries and explicitly define delegation of Evidence and Legal case management functions to designated systems.

Review Change Stack

…n model

ChittyBooks was deprecated on 2026-05-27 (chittyapps/chittybooks#2). Its
"consumes ChittyFinance as engine" line was aspirational with zero consumer
code; substance audit found both its unique features already exist here.

This Charter update:
- Removes the "ChittyBooks consumes ChittyFinance as engine" line from
  IS NOT Responsible For (no longer aspirational — Finance IS the bookkeeping UI)
- Notes that ledger writes flow through ChittyLedger substrate as the Finance
  projection per the canonical ChittyLedger projection model
- Renames "Evidence management (ChittyLedger)" to reflect the projection model
  (substrate is shared; Evidence is a projection like Finance)

See: CHITTYOS/chittymarket docs/remediation/2026-05-27-finance-books-functioning-as-intended.md
See: chittyapps/chittybooks#2

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 27, 2026 21:37
@github-actions
Copy link
Copy Markdown
Contributor

@coderabbitai review

Please evaluate:

  • Security implications
  • Credential exposure risk
  • Dependency supply chain concerns
  • Breaking API changes

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

📝 Walkthrough

Walkthrough

CHARTER.md is updated to clarify Finance scope boundaries. The "IS NOT Responsible For" section now explicitly delegates evidence management to ChittyLedger's evidence projection and legal case management to ChittyCases. Explanatory text distinguishes ChittyFinance as the bookkeeping UI from ChittyLedger as the system handling ledger writes via the Finance projection.

Changes

Finance Scope Clarification

Layer / File(s) Summary
Finance scope responsibilities and delegations
CHARTER.md
Finance scope's "IS NOT Responsible For" section is revised to clarify that evidence management delegates to ChittyLedger evidence projection, legal case management delegates to ChittyCases, and explanatory text describes ChittyFinance as the bookkeeping UI with ledger writes flowing through ChittyLedger Finance projection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A ledger grows clearer, the boundaries now shine—
Evidence to ChittyLedger, legal to ChittyCases fine!
Finance blooms brighter with delegation well-defined,
Each module knows its role, harmoniously aligned. 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(charter): absorb ChittyBooks deprecation' directly and specifically describes the main change: updating CHARTER.md to reflect ChittyBooks deprecation with related annotation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/absorb-chittybooks-deprecation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ChittyFinance charter documentation to reflect ChittyBooks’ deprecation and to align the scope language with the Ledger “projection” model used across the ecosystem.

Changes:

  • Updates the “IS NOT Responsible For” list to clarify Evidence is handled via ChittyLedger’s Evidence projection.
  • Removes the outdated/aspirational ChittyBooks consumer line and replaces it with a deprecation note stating Finance is the bookkeeping UI.
  • Adds an explicit note that ledger writes flow through ChittyLedger as the Finance projection (with a canonical URI reference).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@claude
Copy link
Copy Markdown

claude Bot commented May 27, 2026

Code Review — chore(charter): absorb ChittyBooks deprecation

Scope: Docs-only (CHARTER.md, +9/-2). No code or contract changes.


Overview

Removes the stale "ChittyBooks consumes ChittyFinance as engine" line, annotates the Evidence and Finance projections on ChittyLedger, and adds a prose block confirming ChittyFinance is now the bookkeeping UI after the ChittyBooks deprecation (2026-05-27).


Issues

1. Structural: prose paragraphs are orphaned inside the IS NOT Responsible For section

The two new paragraphs land after the last bullet of ### IS NOT Responsible For and before ## Dual-Mode Operation, so they visually read as belonging to the IS NOT list — but their content is affirmative ("ChittyFinance IS…", "Ledger writes flow through…"). This is the biggest clarity problem in the diff.

Options:

  • Add a ### Notes on Scope (or ### Superseded Services) subheading before these paragraphs to break them out of the IS NOT block.
  • Move the ChittyBooks sentence to the Mission section, where affirmative positioning language already lives. The Finance-projection sentence could then live in a brief ### ChittyLedger Integration block — or inline in the Scope list itself (the IS Responsible For list already mentions COA, ledger audit, etc.).

2. Last Updated date not bumped

The footer reads:

*Charter Version: 2.0.0 | Last Updated: 2026-05-02*

This PR is dated 2026-05-27 and modifies the charter. The date should be updated.

3. Canonical URI for Evidence projection not provided (minor)

The Finance projection now has a full URI:

chittycanon://core/services/chittyledger#projection/finance

The Evidence projection only gets a parenthetical label. Consistency would suggest adding its URI too, or intentionally omitting it with a note that it isn't yet registered. Not a blocker.

4. External cross-reference legibility (minor)

See `CHITTYAPPS/chittybooks/ARCHIVED.md`.

This is a path in a different repo. Readers inside this repo have no direct navigation path. A canonical URI (chittycanon://…) or a prose note like "archived in the chittybooks repository" would be more durable than a bare file path that could go stale.


What Looks Good

  • Removing the ChittyBooks consumer line is the right call — it was aspirational and is now misleading.
  • The Finance-projection canonical URI is a useful addition; it ties this doc to the canon model precisely.
  • The "Evidence projection" annotation is a small but correct alignment with the projection model.

Verdict

The content is correct. The structural placement of the new paragraphs (orphaned between IS NOT and Dual-Mode) and the stale Last Updated date are the two things worth fixing before merge. Everything else is minor polish.

chitcommit added a commit to chittyos/chittymarket that referenced this pull request May 27, 2026
…oks remediation

Bundle of related changes from a multi-turn session:

Skills (chittymarket overlay routing):
- plugins/chittyos-core/skills/skill-creator/ — overlay that routes all new skill
  authoring through chittymarket (no local ~/.claude/skills/ writes), with
  aggressive description so it wins triggering over upstream Anthropic skill-creator
- plugins/chittyos-core/skills/goal-creator/ — three-block (goal · conditions ·
  not-met-until) pipeline driver; pairs with Claude Code's built-in /goal stop-hook
- marketplace.json + .claude-plugin/marketplace.json — register both skills
  (skill-skill-creator + skill-goal-creator)

Ch1tty servers diff (proposal):
- ch1tty-servers-additions.json — draft additions to ch1tty/servers.json
  closing the gap between claude.ai personal connectors and centralized
  Ch1tty gateway. 14 entries (post-cleanup) including multitenant Mercury,
  multitenant Wave, ChittyFinance as the canonical bookkeeping engine
  (post-ChittyBooks-deprecation), plus high-value third-party (Ahrefs,
  Postman, Docusign, Gmail, GCal, GDrive, Zapier, Twilio, Quo, Mermaid)
  and ChittyOS CUSTOM (Chitty Msg, OpenAI Dev Docs).
- Mercury/Wave entries use multitenant: true + requireTenantParam: true
  per the project_mercury_multitenant memory; one 1Password item per tenant.
- ChittyBooks entry REMOVED (deprecated 2026-05-27, chittyapps/chittybooks#2)
- ChittyFinance entry ADDED as canonical bookkeeping engine, references
  ChittyLedger Finance projection.

Finance/Books remediation:
- docs/remediation/2026-05-27-finance-books-functioning-as-intended.md
  Operational audit of 7 endpoints; verified ChittyFinance is functioning
  (false alarm on /api/v1 — Finance uses /api/<resource>); identified 3 real
  gaps: Stripe webhook secret unset on chittyfinance, 3 secrets unset on
  chittycharge, ChittyBooks not deployed (deprecation already executed in
  chittyapps/chittybooks#2 + chittyapps/chittyfinance#118).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHARTER.md`:
- Around line 54-60: Update the broken archive link in CHARTER.md by replacing
the incorrect reference `CHITTYAPPS/chittybooks/ARCHIVED.md` with the correct
archived document path (find the actual archived file in the repo or docs site
and use that path), and verify the ledger projection URI
`chittycanon://core/services/chittyledger#projection/finance` is registered in
the canon registry (if missing, add the registration entry where canon services
are declared so the projection exists rather than only being referenced in
CHARTER.md).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a6f4d1f7-99ad-4009-b292-a10ec31163ab

📥 Commits

Reviewing files that changed from the base of the PR and between 652917a and 7f10b84.

📒 Files selected for processing (1)
  • CHARTER.md

Comment thread CHARTER.md
Comment on lines +54 to +60
ChittyFinance IS the bookkeeping UI for ChittyOS. The former ChittyBooks
service was deprecated on 2026-05-27 and folded into ChittyFinance — its two
unique features (AI categorization, AI insights) were already present here at
higher quality. See `CHITTYAPPS/chittybooks/ARCHIVED.md`.

Ledger writes flow through the ChittyLedger substrate as the "Finance"
projection (`chittycanon://core/services/chittyledger#projection/finance`).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the ChittyBooks archive documentation reference

# Check if the referenced file exists in the chittybooks repository
gh api repos/CHITTYAPPS/chittybooks/contents/ARCHIVED.md --jq '.name' 2>/dev/null || echo "File not found at CHITTYAPPS/chittybooks/ARCHIVED.md"

# Search for any Finance projection canonical URI references in documentation
rg -n "chittycanon://core/services/chittyledger" --type=md -C2

Repository: chittyapps/chittyfinance

Length of output: 490


Fix the broken ChittyBooks archive reference in CHARTER.md

  • CHITTYAPPS/chittybooks/ARCHIVED.md does not exist at that path (404 from the GitHub contents API); update the reference to the correct archived doc location.
  • Ensure chittycanon://core/services/chittyledger#projection/finance is actually registered in canon (right now it’s only referenced in this charter).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CHARTER.md` around lines 54 - 60, Update the broken archive link in
CHARTER.md by replacing the incorrect reference
`CHITTYAPPS/chittybooks/ARCHIVED.md` with the correct archived document path
(find the actual archived file in the repo or docs site and use that path), and
verify the ledger projection URI
`chittycanon://core/services/chittyledger#projection/finance` is registered in
the canon registry (if missing, add the registration entry where canon services
are declared so the projection exists rather than only being referenced in
CHARTER.md).

@chitcommit
Copy link
Copy Markdown
Contributor Author

Closing — depended on now-aborted chittyapps/chittybooks#2 deprecation. ChittyBooks turned out to be under active development (PostgreSQL + ChittyConnect bank-account flow shipped on main during the audit window). Charter line about ChittyBooks consuming Finance is no longer the right edit to make until the two services' boundaries are re-decided by the operator. See chittyapps/chittybooks#2 close comment.

@chitcommit chitcommit closed this May 27, 2026
@chitcommit chitcommit deleted the chore/absorb-chittybooks-deprecation branch May 27, 2026 21:43
chitcommit added a commit to chittyos/chittymarket that referenced this pull request May 27, 2026
…e-sasquatch (#51)

* feat(chittyos-core): canonicalize chittyauth-token-ops + chittystorage-sasquatch

Sweep upstream-pointer agents into chittymarket. These two were the last
two of the 7-agent set that previously lived only in ~/.codex/skills/ on
workstations without a canonical plugin home:

  ✓ chittycanon-code-cardinal       — already in plugins/chittyos-core/agents/chittyagent-canon.md
  ✓ claude-integration-architect    — already in plugins/chittyos-core/agents/chittyagent-claude.md
  ✓ chittyconnect-concierge         — already in plugins/chittyos-core/agents/chittyagent-connect.md
  ✓ chittyregister-compliance-sergeant — already in plugins/chittyos-core/agents/chittyagent-register.md
  ✓ chittyschema-overlord           — already in plugins/chittyos-core/agents/chittyagent-schema.md (pointer)
  +  chittyauth-token-ops           → added here (F2 service-role slug)
  +  chittystorage-sasquatch        → added here (F2 service-role slug)

The two new entries use the <service>-<role> F2 slug form throughout
(canonical filename = projection dir = frontmatter name) for codex-smoke
strictness; the other 5 chittyagent-* entries continue using the
family-prefix form. Both forms are valid per chittycanon GOVERNANCE.md
@ 773b5f4.

Files:
- canonical/agents/{chittyauth-token-ops,chittystorage-sasquatch}.md
- plugins/chittyos-core/agents/{chittyauth-token-ops,chittystorage-sasquatch}.md (projection)
- plugins/chittyos-core/codex-skills/{chittyauth-token-ops,chittystorage-sasquatch}/SKILL.md (projection)
- canonical/.dispatch-state/agents/{chittyauth-token-ops,chittystorage-sasquatch}.json (auto)

Validators:
- lint-plugins: All clear
- test-plugins: 72/72 (was 70/70)
- codex-smoke: 39/39 (was 37/37)
- openclaw-smoke: 10/10
- heal-chittymarket: clean
- generate-marketplace: idempotent
- dispatch sync: idempotent

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(skills+servers): skill-creator overlay, goal-creator, finance/books remediation

Bundle of related changes from a multi-turn session:

Skills (chittymarket overlay routing):
- plugins/chittyos-core/skills/skill-creator/ — overlay that routes all new skill
  authoring through chittymarket (no local ~/.claude/skills/ writes), with
  aggressive description so it wins triggering over upstream Anthropic skill-creator
- plugins/chittyos-core/skills/goal-creator/ — three-block (goal · conditions ·
  not-met-until) pipeline driver; pairs with Claude Code's built-in /goal stop-hook
- marketplace.json + .claude-plugin/marketplace.json — register both skills
  (skill-skill-creator + skill-goal-creator)

Ch1tty servers diff (proposal):
- ch1tty-servers-additions.json — draft additions to ch1tty/servers.json
  closing the gap between claude.ai personal connectors and centralized
  Ch1tty gateway. 14 entries (post-cleanup) including multitenant Mercury,
  multitenant Wave, ChittyFinance as the canonical bookkeeping engine
  (post-ChittyBooks-deprecation), plus high-value third-party (Ahrefs,
  Postman, Docusign, Gmail, GCal, GDrive, Zapier, Twilio, Quo, Mermaid)
  and ChittyOS CUSTOM (Chitty Msg, OpenAI Dev Docs).
- Mercury/Wave entries use multitenant: true + requireTenantParam: true
  per the project_mercury_multitenant memory; one 1Password item per tenant.
- ChittyBooks entry REMOVED (deprecated 2026-05-27, chittyapps/chittybooks#2)
- ChittyFinance entry ADDED as canonical bookkeeping engine, references
  ChittyLedger Finance projection.

Finance/Books remediation:
- docs/remediation/2026-05-27-finance-books-functioning-as-intended.md
  Operational audit of 7 endpoints; verified ChittyFinance is functioning
  (false alarm on /api/v1 — Finance uses /api/<resource>); identified 3 real
  gaps: Stripe webhook secret unset on chittyfinance, 3 secrets unset on
  chittycharge, ChittyBooks not deployed (deprecation already executed in
  chittyapps/chittybooks#2 + chittyapps/chittyfinance#118).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(canonical): runtimes limited to claude-code+codex (dispatch.sh valid set for kind=skill)

dispatch.sh only handles claude-code:skill and codex:skill projections.
Other runtimes apply only to kind=agent. Trimmed runtime list to the valid
set; dispatch sync now succeeds for both new skills.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(remediation): record PR-A/PR-B abort — ChittyBooks under active dev

Substance audit was against stale main. ChittyBooks shipped 6 commits during
the audit window adding SQLite/PostgreSQL + ChittyConnect bank-account flow.
Deprecation thesis no longer holds.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants