Skip to content

Conversation

@domkun
Copy link
Contributor

@domkun domkun commented Feb 19, 2024

Adds the ability to configure the plugin using system properties.

System propertiers are prefixed with glcqpto avoid conflicts with other plugins. The system property names correspond to the field names of the mojo.

Copy link
Owner

@chkal chkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot for your contribution. This look great. Just one minor comment regarding the README.adoc change.

@chkal chkal self-assigned this Feb 20, 2024
@domkun
Copy link
Contributor Author

domkun commented Feb 20, 2024

Thanks for the plugin in the first place :) Feel free to change it how it fits best. Or just tell me what I should change.

Copy link
Owner

@chkal chkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, somehow my comment got lost. Here it is.

Co-authored-by: Christian Kaltepoth <christian@kaltepoth.de>
Copy link
Owner

@chkal chkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@chkal chkal merged commit f6b1ad0 into chkal:master Feb 27, 2024
@chkal chkal added this to the 1.1.0 milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants