Skip to content

chore: address re-review findings from PR #147#148

Merged
chmmou merged 1 commit into
mainfrom
fix/session-delete-rereview
May 15, 2026
Merged

chore: address re-review findings from PR #147#148
chmmou merged 1 commit into
mainfrom
fix/session-delete-rereview

Conversation

@chmmou

@chmmou chmmou commented May 15, 2026

Copy link
Copy Markdown
Owner

Re-review fixes for the sessions delete slice (#60 / PR #147):

  • S1: internal/session/store.go no longer carries a second package-doc comment that duplicated/narrowed doc.go; the persistence prose moved onto the Store type and doc.go is now the sole authoritative package doc.
  • S2: sessions delete now prints a "cleared the local cache" note on the non-unknown_session failure path, so a failed-but-partially-applied state is not silent without --verbose.
  • N1: session.Client.Delete guards against a nil response from a misbehaving Caller.
  • N2: sessions delete --help states the global --yes flag has no effect.

@chmmou chmmou merged commit 4a1e784 into main May 15, 2026
6 checks passed
@chmmou chmmou deleted the fix/session-delete-rereview branch May 15, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant