chore: address re-review findings from PR #147#148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-review fixes for the
sessions deleteslice (#60 / PR #147):internal/session/store.gono longer carries a second package-doc comment that duplicated/narroweddoc.go; the persistence prose moved onto theStoretype anddoc.gois now the sole authoritative package doc.sessions deletenow prints a "cleared the local cache" note on the non-unknown_sessionfailure path, so a failed-but-partially-applied state is not silent without--verbose.session.Client.Deleteguards against a nil response from a misbehaving Caller.sessions delete --helpstates the global--yesflag has no effect.