feat(ftpuser): write endpoints — add / update / delete#178
Merged
Conversation
Wire add_ftpuser / update_ftpuser / delete_ftpuser through the shared internal/kaswrite seam. update and delete are #109-gated; add is reversible and not prompted. add_ftpuser takes no ftp_login (KAS generates it, echoed in ReturnInfo); the password key differs by action (ftp_password on add, ftp_new_password on update). Resolves the #13 plural-vs-singular question: the live action is add_ftpuser (singular); add_ftpusers is only the internal PHP function name. Closes #119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires
add_ftpuser/update_ftpuser/delete_ftpuserthrough the sharedinternal/kaswriteseam (#119, #13 write slice).ftpusers add --password <pw> --comment <c> [flags]— non-gated (reversible), still--dry-run+ audited. KAS generates the login; it is printed on success.ftpusers update <ftp-login> [flags]/delete <ftp-login>— feat(cli): destructive-write confirmation infrastructure (--yes / interactive prompt) #109-gated.updatesends only the cobra-Changedflags (empty value = deliberate clear).ftp_passwordon add,ftp_new_passwordon update; redacted in dry-run/audit.add_ftpuser(singular);add_ftpusersis only the internal PHP function name — no fixture change needed.Closes #119