Fix bugs, improve docs, and expand test coverage#20
Merged
Conversation
- Fix stale doc link in error.rs (Buffer → Batch) - Fix copy-paste bugs polling ready1 instead of ready2 in wakes_pending_waiters_on_close and wakes_pending_waiters_on_failure - Fix fetch_add double-counting in test Aggregator - Add doc comments to Handle, Bridge, Lot, and State in worker.rs - Verify multiple size-based flushes produce separate batches - Verify batch items arrive in insertion order - Verify cloned Batch handles all deliver items to the backing service - Verify multiple time-based flushes produce separate batches - Verify concurrent clones succeed under inner service back-pressure
chmodas
force-pushed
the
minor-improvements
branch
from
e24b97f to
8ebb62c
Compare
Fix a bug where the worker would not terminate after a poll_ready failure during the Flushing state (flush_fut: None). The error path now transitions to Finished and returns, matching the existing flush_fut: Some behavior. Add five tests covering previously untested code paths: BatchLayer construction and Debug, error Display/Debug/source formatting, ResponseFuture::failed on dead worker, flush-phase poll_ready failure, and cancelled-request skipping in the channel loop.
Pin all GitHub Actions to commit SHAs to prevent supply chain attacks. Add cargo fmt check, install cargo-llvm-cov for coverage reporting, and upload results to Codecov.
chmodas
force-pushed
the
minor-improvements
branch
from
8ebb62c to
7452a66
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.